.github/workflows/coderabbit-execution-plan-flow.md (3)

66-66: Add language identifier to fenced code blocks for markdown linting compliance.

Several code blocks lack a language specifier. Add the appropriate language identifier after the opening triple backticks.

- ```
+ ```bash

Apply this pattern to lines 66, 108, 113, 118, and 130 (use bash for shell commands, remove for plain text code blocks where appropriate).

Also applies to: 108-108, 113-113, 118-118, 130-130

---

93-93: Replace bold emphasis with proper heading syntax for improved markdown structure.

Lines 93, 98, 107, 112, and 117 use emphasis (**Option N**) where headings would be more semantic. Replace with markdown headings:

- **Option 1: Request execution plan**
+ ### Option 1: Request execution plan

Apply similarly to the other "Option" lines to improve document structure.

Also applies to: 98-98, 107-107, 112-112, 117-117

---

165-165: Capitalize "GitHub" in documentation reference.

Line 165 should capitalize the product name consistently.

- - **Consolidated workflow:** `.github/workflows/coderabbit-test-execution-plan.yml`
+ - **Consolidated workflow:** `.github/workflows/coderabbit-test-execution-plan.yml`

(Note: Verify capitalization of "GitHub" per project style guide.)

.github/workflows/coderabbit-test-execution-plan.yml (2)

77-123: Refactor: Extract duplicate commit-checking logic into a shared step or action.

Both Job 1 (lines 77-123) and Job 3 (lines 254-300) contain near-identical logic for validating that /verified commands are on the last commit. Consider consolidating this into a reusable workflow step or a separate action to reduce duplication and maintenance burden.

Also applies to: 254-300

---

302-342: Clarify CodeRabbit review expectations in the request prompt.

The review request at lines 314-341 provides detailed guidance to CodeRabbit, which is good. However, clarify whether CodeRabbit should post the "Test execution plan verified" message as a pull request review comment (on Files Changed) or as a regular PR comment. The current guidance mentions "Respond as a review comment on the Files Changed tab if providing specific test instructions" but doesn't explicitly state where to post the verification message.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 0
File: :0-0
Timestamp: 2025-09-29T19:05:24.987Z
Learning: The test execution plan for PR #1904 focuses on cluster-type conditional logic where nmstate functionality is bypassed on cloud clusters (Azure/AWS) but fully functional on bare-metal/PSI clusters, requiring different test strategies for each environment type.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1168
File: tests/storage/storage_migration/utils.py:92-99
Timestamp: 2025-06-10T09:41:58.035Z
Learning: When CodeRabbit flags technical issues in code reviews, do not resolve the comments without first addressing them and getting a response from the user. Proper procedure is to discuss the technical issues and proposed solutions before marking comments as resolved.

.github/scripts/coderabbit_workflow.py (6)

49-59: Apply static analysis suggestion and add label validation.

The code correctly handles 404 errors but has a minor style issue flagged by static analysis. Also add label validation for consistency.

Apply this diff:

 def remove_label(self, pr_number: int, label: str) -> bool:
+    if not label or not label.strip():
+        raise ValueError("Label cannot be empty")
     try:
         issue = self.get_issue(pr_number=pr_number)
         issue.remove_from_labels(*[label])
         LOGGER.info(f"Removed label: {label}")
         return True
     except GithubException as e:
         if e.status == 404:
             LOGGER.info(f"Label not present: {label}")
             return False
-        raise
+        else:
+            raise

---

67-140: Extract embedded templates to external files for maintainability.

The two large embedded prompt templates make the code harder to maintain, test, and version independently.

Consider extracting these templates to separate files:

Create .github/templates/request_plan_template.md:

@coderabbitai
<details>
  <summary>Test execution plan request details</summary>
  ...
</details>

Create .github/templates/review_request_template.md:

@coderabbitai
<details>
  <summary>Test Execution Plan Review Request</summary>
  ...
</details>

Then load them in __init__:

def __init__(self, client: GitHubClient) -> None:
    self.client = client
    template_dir = Path(__file__).parent.parent / "templates"
    self.request_plan_template = (template_dir / "request_plan_template.md").read_text()
    self.review_request_template = (template_dir / "review_request_template.md").read_text()

This improves maintainability and allows template testing independently.

---

176-186: Clarify /verified command behavior and return value usage.

The method handles both /generate-execution-plan and /verified commands identically by posting the same template, which may be confusing. Additionally, the return value is unused by the caller.

Consider:

1. Separate the two commands if they should have different behaviors
2. Remove the unused return value or document its purpose
3. Add a comment explaining why /verified triggers a plan request

 def request_execution_plan(self, pr_number: int, commenter: str, has_generate: bool) -> bool:
-    LOGGER.info("User requested test execution plan")
+    if has_generate:
+        LOGGER.info("User requested test execution plan via /generate-execution-plan")
+    else:
+        LOGGER.info("User triggered plan generation via /verified without existing plan")

     cmd = "generate-execution-plan" if has_generate else "verified"
     if not self._verify_team_membership(username=commenter, command=cmd):
         return False

     self.client.create_comment(pr_number=pr_number, body=self.REQUEST_PLAN_TEMPLATE)
     LOGGER.info("Requested test execution plan from CodeRabbit")

     return has_generate

---

232-236: Apply static analysis suggestion: use logging.exception for better error context.

Replace LOGGER.error with LOGGER.exception to automatically include the traceback, making debugging easier.

Apply this diff:

     try:
         owner, repo = repository.split("/")
     except ValueError:
-        LOGGER.error(f"Invalid repository format: {repository}")
+        LOGGER.exception(f"Invalid repository format: {repository}")
         sys.exit(1)

---

238-242: Apply static analysis suggestion: use logging.exception for better error context.

Replace LOGGER.error with LOGGER.exception to automatically include the traceback.

Apply this diff:

     try:
         pr_number: Optional[int] = int(pr_number_str) if pr_number_str else None
     except ValueError:
-        LOGGER.error(f"Invalid PR number: {pr_number_str}")
+        LOGGER.exception(f"Invalid PR number: {pr_number_str}")
         sys.exit(1)

---

283-284: Use regex or exact word boundaries for command detection.

Substring matching for commands can cause false positives. For example, a comment like "Do not /generate-execution-plan-now" would trigger the command.

Apply this diff to use word boundaries:

+    import re
+
     body_lower = body.lower()
-    has_generate = "/generate-execution-plan" in body_lower
-    has_verified = "/verified" in body_lower
+    has_generate = bool(re.search(r'\b/generate-execution-plan\b', body_lower))
+    has_verified = bool(re.search(r'\b/verified\b', body_lower))

Or add the import at the top of the file and update these lines accordingly.

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1168
File: tests/storage/storage_migration/utils.py:92-99
Timestamp: 2025-06-10T09:41:58.035Z
Learning: When CodeRabbit flags technical issues in code reviews, do not resolve the comments without first addressing them and getting a response from the user. Proper procedure is to discuss the technical issues and proposed solutions before marking comments as resolved.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

.github/scripts/coderabbit_workflow.py (8)

23-27: Add input validation for initialization parameters.

The constructor lacks validation for token, owner, and repo_name. Empty or invalid values will cause failures downstream when making API calls.

---

29-36: Improve error handling to distinguish membership failures from API errors.

Treating all GithubException cases as non-membership is incorrect. A network failure, authentication error, or rate limit will incorrectly deny access to legitimate team members.

---

38-39: Add input validation for PR number.

The method doesn't validate that pr_number is a positive integer, which could lead to API errors.

---

45-48: Validate label parameter.

Empty or whitespace-only labels should be rejected before making the API call.

---

65-67: Validate comment body before posting.

Empty comments or excessively long comments should be rejected. GitHub has a comment length limit (around 65,536 characters).

---

202-204: Auto-resolve invalid label state instead of skipping.

When both labels are present, the workflow should automatically resolve to a consistent state rather than silently skipping. This prevents the workflow from becoming stuck.

---

225-311: Add concurrency control documentation.

The workflow lacks concurrency control, which can lead to race conditions when multiple events occur simultaneously on the same PR. This should be documented and handled at the GitHub Actions workflow level.

---

275-277: Use exact match for bot name detection to avoid false positives.

Substring matching for "renovate" in commenter could match usernames like "user-renovate" or "renovate-test".

.github/scripts/coderabbit_workflow.py (3)

50-64: Minor style improvements for exception handling.

The exception handling is correct, but static analysis suggests two minor style improvements: extracting the error message to the exception class definition, and moving the return True to an else block for clarity.

Apply this diff for cleaner exception handling:

 def remove_label(self, pr_number: int, label: str) -> bool:
     if not label or not label.strip():
         raise ValueError("Label cannot be empty")
     try:
         issue = self.get_issue(pr_number=pr_number)
         issue.remove_from_labels(*[label])
         LOGGER.info(f"Removed label: {label}")
-        return True
     except GithubException as e:
         if e.status == 404:
             LOGGER.info(f"Label not present: {label}")
             return False
         else:
             raise
+    else:
+        return True

---

71-144: Consider extracting large template strings to external files.

The embedded prompt templates (110+ lines total) make the class harder to maintain and test. Consider moving them to separate template files (e.g., .github/templates/request_plan.md and .github/templates/review_request.md) and loading them at runtime.

This would improve:

• Maintainability: Templates can be edited without touching Python code
• Testability: Templates can be validated independently
• Clarity: Class focuses on workflow logic rather than prompt content

---

239-249: Use logging.exception for better error diagnostics.

When logging errors in exception handlers, use LOGGER.exception() instead of LOGGER.error() to automatically include the stack trace.

Apply this diff:

     try:
         owner, repo = repository.split("/")
     except ValueError:
-        LOGGER.error(f"Invalid repository format: {repository}")
+        LOGGER.exception(f"Invalid repository format: {repository}")
         sys.exit(1)
 
     try:
         pr_number: Optional[int] = int(pr_number_str) if pr_number_str else None
     except ValueError:
-        LOGGER.error(f"Invalid PR number: {pr_number_str}")
+        LOGGER.exception(f"Invalid PR number: {pr_number_str}")
         sys.exit(1)

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1168
File: tests/storage/storage_migration/utils.py:92-99
Timestamp: 2025-06-10T09:41:58.035Z
Learning: When CodeRabbit flags technical issues in code reviews, do not resolve the comments without first addressing them and getting a response from the user. Proper procedure is to discuss the technical issues and proposed solutions before marking comments as resolved.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

.github/scripts/coderabbit_workflow.py (2)

287-289: Tighten Renovate bot detection to avoid substring false positives

The current check if RENOVATE_BOT in commenter.lower(): (with RENOVATE_BOT = "renovate") will also skip comments from users whose names merely contain “renovate” (e.g., user-renovate-test).

To avoid skipping legitimate users, consider an exact or prefix match on the canonical Renovate bot name, for example:

-        if RENOVATE_BOT in commenter.lower():
+        commenter_l = commenter.lower()
+        if commenter_l == "renovate[bot]" or commenter_l.startswith("renovate["):
             LOGGER.info("Renovate comment, skipping")
             return

---

30-44: Don’t treat all non‑404 GitHub API errors as “not a team member”

Right now is_user_in_team logs any non‑404 GithubException and returns False, which silently blocks legitimate team members when there are auth, rate‑limit, or transient API issues. This also conflicts with the otherwise fail‑fast style in main().

Consider re‑raising for non‑404 statuses so these conditions surface clearly and fail the workflow instead of being misinterpreted as lack of membership, for example:

     except GithubException as ex:
         if ex.status == 404:
             LOGGER.info(f"Team '{team_slug}' not found or user '{username}' not found")
             return False

-        LOGGER.error(f"GitHub API error checking team membership: {ex.status} - {ex.data}")
-        return False
+        LOGGER.exception("GitHub API error checking team membership")
+        raise

.github/workflows/coderabbit-execution-plan-flow.md (1)

134-165: Add languages to fenced code blocks to satisfy markdownlint and improve rendering

Several fenced code blocks omit a language, which markdownlint flags (MD040):

• State diagram at Lines 134–165
• Lifecycle example at Lines 211–245
• Test execution plan example at Lines 253–259
• Verification phrase example at Lines 263–265

Consider annotating them with something like text to keep them neutral but lint‑clean, for example:

```text
Test execution plan verified

Also applies to: 211-245, 253-265

</blockquote></details>

</blockquote></details>

<details>
<summary>📜 Review details</summary>

**Configuration used**: CodeRabbit UI

**Review profile**: CHILL

**Plan**: Pro

<details>
<summary>📥 Commits</summary>

Reviewing files that changed from the base of the PR and between e3b4da38d0c263a42e30348756aa599ac187a1fc and 87fdfc6289f4c3fa3369f595b92815cad0ed5ca9.

</details>

<details>
<summary>⛔ Files ignored due to path filters (1)</summary>

* `uv.lock` is excluded by `!**/*.lock`

</details>

<details>
<summary>📒 Files selected for processing (3)</summary>

* `.github/scripts/coderabbit_workflow.py` (1 hunks)
* `.github/workflows/coderabbit-execution-plan-flow.md` (1 hunks)
* `pyproject.toml` (1 hunks)

</details>

<details>
<summary>🧰 Additional context used</summary>

<details>
<summary>🧠 Learnings (3)</summary>

<details>
<summary>📓 Common learnings</summary>

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1168
File: tests/storage/storage_migration/utils.py:92-99
Timestamp: 2025-06-10T09:41:58.035Z
Learning: When CodeRabbit flags technical issues in code reviews, do not resolve the comments without first addressing them and getting a response from the user. Proper procedure is to discuss the technical issues and proposed solutions before marking comments as resolved.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

</details>
<details>
<summary>📚 Learning: 2025-11-25T01:56:54.902Z</summary>

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

**Applied to files:**
- `.github/scripts/coderabbit_workflow.py`

</details>
<details>
<summary>📚 Learning: 2025-11-27T11:45:54.194Z</summary>

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.194Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.

**Applied to files:**
- `.github/scripts/coderabbit_workflow.py`

</details>

</details><details>
<summary>🪛 LanguageTool</summary>

<details>
<summary>.github/workflows/coderabbit-execution-plan-flow.md</summary>

[uncategorized] ~332-~332: The official name of this software platform is spelled with a capital “H”.
Context: ...-instructions.yml` - **Documentation:** `.github/workflows/coderabbit-execution-plan-flo...

(GITHUB)

</details>

</details>
<details>
<summary>🪛 markdownlint-cli2 (0.18.1)</summary>

<details>
<summary>.github/workflows/coderabbit-execution-plan-flow.md</summary>

134-134: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

211-211: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

253-253: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

---

263-263: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>
<details>
<summary>🪛 Ruff (0.14.6)</summary>

<details>
<summary>.github/scripts/coderabbit_workflow.py</summary>

42-42: Use `logging.exception` instead of `logging.error`

Replace with `exception`

(TRY400)

---

59-59: Avoid specifying long messages outside the exception class

(TRY003)

---

64-64: Consider moving this statement to an `else` block

(TRY300)

---

254-254: Use `logging.exception` instead of `logging.error`

Replace with `exception`

(TRY400)

</details>

</details>

</details>

<details>
<summary>🔇 Additional comments (1)</summary><blockquote>

<details>
<summary>pyproject.toml (1)</summary><blockquote>

`99-106`: **Ensure CI installs the dev dependency group for the workflow script**

Adding `pygithub` and `python-simple-logger` to the `dev` group makes sense for the GitHub automation script, but the workflow container must actually install this group (e.g., via `uv`/`pip` with extras) before running `.github/scripts/coderabbit_workflow.py`, otherwise imports from `github` will fail at runtime. Please confirm the workflow does this.

</blockquote></details>

</blockquote></details>

</details>

<!-- This is an auto-generated comment by CodeRabbit for review status -->

.github/workflows/request-coderabbit-test-instructions.yml (1)

26-28: Concurrency control properly implemented.

The concurrency configuration prevents race conditions when multiple events fire simultaneously on the same PR. Setting cancel-in-progress: false ensures all events are processed sequentially without cancellation, which is the correct approach for label management operations.

.github/scripts/coderabbit_workflow.py (1)

320-322: Tighten Renovate bot detection to avoid false positives.

The substring check RENOVATE_BOT in commenter.lower() will match usernames like "user-renovate" or "my-renovate-fork". Use exact matching or a pattern that specifically targets Renovate bot accounts.

Apply this diff:

-        if RENOVATE_BOT in commenter.lower():
+        if commenter.lower() == RENOVATE_BOT or commenter.lower().startswith("renovate["):
             LOGGER.info("Renovate comment, skipping")
             return

.github/scripts/coderabbit_workflow.py (4)

82-82: Use LOGGER.exception instead of LOGGER.error in exception handlers.

When logging inside exception handlers, LOGGER.exception automatically includes the full traceback, which is more useful for debugging than LOGGER.error.

Apply this diff at line 82:

-            LOGGER.error(f"Failed to remove label '{label}' from PR #{pr_number}: {e.status} - {e.data}")
+            LOGGER.exception(f"Failed to remove label '{label}' from PR #{pr_number}: {e.status} - {e.data}")

Apply this diff at line 290:

-        LOGGER.error(f"Invalid repository format: {repository}")
+        LOGGER.exception(f"Invalid repository format: {repository}")

Apply this diff at line 297:

-            LOGGER.error(f"Invalid PR number format: '{pr_number_str}' - must be integer")
+            LOGGER.exception(f"Invalid PR number format: '{pr_number_str}' - must be integer")

Also applies to: 290-290, 297-297

---

67-67: Remove unused noqa directives.

The noqa: FCN001 directives reference an unknown rule code and can be safely removed.

Apply this diff at line 67:

-        issue.add_to_labels(label)  # noqa: FCN001
+        issue.add_to_labels(label)

Apply this diff at line 75:

-            issue.remove_from_labels(label)  # noqa: FCN001
+            issue.remove_from_labels(label)

Also applies to: 75-75

---

71-72: Consider extracting the error message to a constant.

The validation at line 71-72 prevents empty labels, which is good defensive coding. However, Ruff suggests avoiding long messages directly in raise statements for better maintainability.

If you want to address the Ruff hint:

+EMPTY_LABEL_ERROR = "Label cannot be empty"
+
 def remove_label(self, pr_number: int, label: str) -> bool:
     if not label or not label.strip():
-        raise ValueError("Label cannot be empty")
+        raise ValueError(EMPTY_LABEL_ERROR)

Alternatively, you can leave it as-is since the message is clear and concise.

---

73-83: Consider moving the return to an else block for clarity.

Ruff suggests making the success path more explicit by using an else block instead of relying on the exception to prevent execution.

Apply this diff:

         try:
             issue = self.get_issue(pr_number=pr_number)
             issue.remove_from_labels(label)
             LOGGER.info(f"Removed label: {label}")
-            return True
         except GithubException as e:
             if e.status == 404:
                 LOGGER.info(f"Label not present: {label}")
                 return False
             LOGGER.exception(f"Failed to remove label '{label}' from PR #{pr_number}: {e.status} - {e.data}")
             raise
+        else:
+            return True

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

Learnt from: servolkov
Repo: RedHatQE/openshift-virtualization-tests PR: 2838
File: .github/workflows/net-utils-builder-staging.yml:37-37
Timestamp: 2025-11-25T01:56:54.902Z
Learning: In the openshift-virtualization-tests repository, when renaming container images that are built and used by GitHub Actions workflows, the changes must be done sequentially: first merge the workflow files (.github/workflows/) that update the image name in the CI/CD pipelines, then update the code references (like constants.py and manifest files) in a follow-up PR. This prevents the old workflow from running with mismatched image names during the transition.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1168
File: tests/storage/storage_migration/utils.py:92-99
Timestamp: 2025-06-10T09:41:58.035Z
Learning: When CodeRabbit flags technical issues in code reviews, do not resolve the comments without first addressing them and getting a response from the user. Proper procedure is to discuss the technical issues and proposed solutions before marking comments as resolved.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2701
File: .github/scripts/coderabbit_workflow.py:45-46
Timestamp: 2025-11-27T11:45:54.224Z
Learning: In the openshift-virtualization-tests repository, when using the PyGithub library or similar API clients, rnetser prefers to rely on API-level validation rather than adding redundant client-side input validation, since the API will handle validation and raise appropriate errors.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2469
File: utilities/sanity.py:139-142
Timestamp: 2025-11-08T07:36:57.616Z
Learning: In the openshift-virtualization-tests repository, user rnetser prefers to keep refactoring PRs (like PR #2469) strictly focused on moving/organizing code into more granular modules without adding new functionality, error handling, or behavioral changes. Such improvements should be handled in separate PRs.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1244
File: utilities/os_utils.py:248-250
Timestamp: 2025-07-08T05:51:06.314Z
Learning: User rnetser prefers fail-fast code design where functions should raise exceptions immediately when encountering unexpected or malformed input, rather than implementing defensive error handling with fallbacks. They value making problems visible immediately during development over graceful degradation.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2477
File: utilities/infra.py:0-0
Timestamp: 2025-11-03T18:00:07.145Z
Learning: In the RedHatQE/openshift-virtualization-tests repository, prefer using the union operator `|` for catching multiple exception types (e.g., `except ResourceNotFoundError | NotFoundError:`) instead of the parenthesized tuple syntax, as the codebase uses Python 3.14 which fully supports PEP 604.

Learnt from: OhadRevah
Repo: RedHatQE/openshift-virtualization-tests PR: 1989
File: tests/observability/runbook_url/conftest.py:23-23
Timestamp: 2025-09-11T07:16:31.186Z
Learning: In tests/observability/runbook_url/conftest.py, the user OhadRevah prefers to let test fixtures fail explicitly when Prometheus rule annotations are missing rather than using defensive programming with default dictionaries. This aligns with their general preference for simple assertions in pytest fixtures.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 2340
File: utilities/bitwarden.py:58-84
Timestamp: 2025-10-27T20:34:44.172Z
Learning: In the openshift-virtualization-tests repository, when a package provides an exception (e.g., json.JSONDecodeError), use that exception directly rather than wrapping it in a custom exception like ValueError. This applies to utilities/bitwarden.py and similar modules throughout the codebase.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1236
File: conftest.py:539-557
Timestamp: 2025-06-18T13:26:04.504Z
Learning: In the openshift-virtualization-tests repository, PR #1236 intentionally limits error extraction to the setup phase only in the pytest_runtest_makereport hook. The scope is deliberately restricted to setup failures, not all test phases.

Learnt from: rnetser
Repo: RedHatQE/openshift-virtualization-tests PR: 1028
File: utilities/infra.py:1249-1254
Timestamp: 2025-08-06T13:57:51.928Z
Learning: User rnetser verified that all calls to get_infrastructure() function use the admin_client parameter, confirming that signature changes requiring this parameter don't cause breaking changes in the openshift-virtualization-tests codebase.

Learnt from: dshchedr
Repo: RedHatQE/openshift-virtualization-tests PR: 1716
File: tests/virt/conftest.py:289-297
Timestamp: 2025-08-09T01:52:26.683Z
Learning: When user dshchedr moves working code from one location to another in the openshift-virtualization-tests repository, they prefer not to modify it unless there's a real issue, maintaining the original implementation to avoid introducing unnecessary changes.